fix(@angular/cli): fix asset watching - #7600
Merged
Merged
Conversation
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed. Fix angular#7521
filipesilva
force-pushed
the
fix-asset-refresh
branch
from
September 5, 2017 14:25
0ac7524 to
5cb7fc7
Compare
clydin
reviewed
Sep 5, 2017
| export function isDirectory(path: string) { | ||
| try { | ||
| return fs.statSync(path).isDirectory(); | ||
| } catch (_) { |
Member
There was a problem hiding this comment.
If TS is upgraded to 2.5.2 for CLI build purposes, the empty catch variable can be removed
Contributor
Author
There was a problem hiding this comment.
We should do that project wide when updating.
hansl
approved these changes
Sep 5, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.
Fix #7521